Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[temp] feat(@nestjs/core): Add Transient Inquirer Injection #3410

Closed
wants to merge 3 commits into from

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Original PR #1637

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@kamilmysliwiec
Copy link
Member Author

Original PR #1637

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7318

  • 14 of 15 (93.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 95.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/injector.ts 7 8 87.5%
Totals Coverage Status
Change from base Build 7307: -0.008%
Covered Lines: 4407
Relevant Lines: 4624

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec deleted the gojob-1337-transient-inject-inquirer branch January 23, 2020 14:33
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants