Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): run bootstrap hook after listen server. (#2795) #2907

Closed
wants to merge 1 commit into from

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Sep 9, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 2795

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@underfin
Copy link
Contributor Author

@hardcodet ,I think it as well. But something can be invoke with other hook, the onApplicationBootstrap hook should called after the server listened.

@kamilmysliwiec
Copy link
Member

@hardcodet ,I think it as well. But something can be invoke with other hook, the onApplicationBootstrap hook should called after the server listened.

I'm not entirely sure about that. onApplicationBootstrap is called for other application types as well, like hybrid app or context app. This change would bring inconsistency between them.

@underfin
Copy link
Contributor Author

OK, I will work it for other hook.

@underfin underfin deleted the onApplicationListen branch September 17, 2019 11:19
@lock
Copy link

lock bot commented Dec 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants