Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(websockets): Prevent HTTP server early close in Socket.IO shutdown #14185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sapenlei
Copy link

@sapenlei sapenlei commented Nov 21, 2024

fixes #13910

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #13910

What is the new behavior?

When ws connections and other long-running connections are handled by the same HTTP server instance, the shutdown process will not be blocked, allowing for proper termination of all connection types.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 1f935bcf-2e20-49d2-8b77-6a4688c12cf5

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.989%

Totals Coverage Status
Change from base Build 118b06bc-2db5-429c-9b45-ae989ad7db1e: 0.0%
Covered Lines: 6809
Relevant Lines: 7402

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket.IO Adapter Close causes premature HTTP Server close() call and blocks application shutdown
3 participants