feat(core): disambiguate string-based providers from class-based providers on error message #12445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
when some provider registered with a string token is missing, the error message is the same as the ones registered with classes
I believe this confuse people sometimes specially when the token is created by 3rd-party libs and, on the consumer side, there is a class with the same name
For example:
What is the new behavior?
I believe that this minor change would decrease the debugging time spent of resolving such errors. But I don't know if not having quotes around provider's name was intentional in first place.
Does this PR introduce a breaking change?