feat(microservices): handle kafka consumer crashes #11910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to react to consumer crashes within kafkajs, which are not retryable, the ClientKafka and ServerKafka have to listen to CRASH events and act accordingly. Listen to CRASH events and throw an exception, if the crash is not retried. Documentation: https://kafka.js.org/docs/instrumentation-events#a-name-consumer-a-consumer
Pull Request Test Coverage Report for Build 3cfd9218-59df-4aa0-9b37-47f96a0aeb4f
💛 - Coveralls |
|
looks like the integration tests failed on the websocket adapter, which was not touched by this PR |
1 task
|
will close the PR for now, since there are some other discussion in related PR in #11616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to react to consumer crashes within kafkajs, which are not retryable, the ClientKafka and ServerKafka have to listen to CRASH events and act accordingly. Listen to CRASH events and throw an exception, if the crash is not retried.
Documentation: https://kafka.js.org/docs/instrumentation-events#a-name-consumer-a-consumer
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Whenever the kafka consumer crashes, the application will not cleanly shutdown. The rest of the application will still work as expected, but no messages from kafka will be consumed
Issue Number: N/A
Related Issue, but not solving it: #11616
What is the new behavior?
Whenever a crash of the kafka consumer is not retriable, the handler will throw an exception to shutdown the nest application
Does this PR introduce a breaking change?
Other information