fix(core): fix flaky durable providers #11666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamalAman
commented
May 25, 2023
Comment on lines
+91
to
+92
| // How to test this? | ||
| // const constructorStub = sinon.stub(DurableService, 'constructor').throws(new Error('test error')); |
There was a problem hiding this comment.
@micalevisk any suggestions on how to use sinon to stub the constructor to throw an error for very first request?
I cannot find any references to that and I don't know if there is a clean way to do that. Any suggestions?
There was a problem hiding this comment.
I don't know either :/ I will try to find something later
micalevisk
suggested changes
May 25, 2023
KamalAman
force-pushed
the
fix-flaky-durable-provider
branch
from
0ff682d
to
3d409e4
Compare
KamalAman
force-pushed
the
fix-flaky-durable-provider
branch
from
3d409e4
to
d5e95a9
Compare
15 tasks
|
i'll try to get back to this over the weekend and close it off |
|
@KamalAman @kamilmysliwiec what was the reason why this PR was never accepted ? i reopened an issue on the matter: #13953 |
|
@dberardo-com yeah this is an annoying bug. I never figured out how to test it. Anyone who wants to pick it up, please feel free to take this over. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #11664
What is the new behavior?
Does this PR introduce a breaking change?
Other information