fix(fastify): return the response on exception #10889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify requires us to return the response object when handling async methods and dealing with exceptions, otherwise a thenable gets wrapped and improperly handled later causing an exception. This is shown by this repo and discuessed in this issue.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If we use a fastify plugin, like
@fastify/compress
and there is an error handled by the exception filter, we end up getting a response without any body, and if theonSend
hook is debugged we will see that it gets called twice, once with the proper response and once with anundefined
payload. Further debugging shows the messageIssue Number: #10736
What is the new behavior?
Because we return the
res
object from therouter-proxy
now, we no longer get this issue with fastify trying to watch for thethenable
and handling it internally.Does this PR introduce a breaking change?
Other information
I have verified that this does not affect express in any way.