nest/src/microservices/client/client-tcp.ts#L43. There is a bug or problem here.

[whtiehack]

nest/src/microservices/client/client-tcp.ts

Lines 40 to 50 in 981104a

	protected async sendSingleMessage(msg, callback: (...args) => any) {
	const sendMessage = socket => {
	socket.sendMessage(msg);
	socket.on(MESSAGE_EVENT, buffer =>
	this.handleResponse(socket, callback, buffer),
	);
	};
	if (this.isConnected) {
	sendMessage(this.socket);
	return Promise.resolve();
	}

I'm submitting a...

[ ] Regression 
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

socket.on(MESSAGE_EVENT, buffer =>
When I provide a wrong pattern.
For example, { cmd: 'sum' } is written as { cmd: 'sum1' }.
Each time you send a message, it binds once. This callback function is called N+1 times.
So is this a performance issue and a memory leak?
Or is there any way to catch the pattern error?

Expected behavior

Can be properly disposed.

Minimal reproduction of the problem with instructions

  @MessagePattern({ cmd: 'sum' })
  sum(data: number[]): number {
    return (data || []).reduce((a, b) => a + b);
  }

and

  @Get('/micro')
  async testMicroService(){
    return await this.microClientService.testMicroClient.send<number>({cmd:'sum1'},[1,2,3,4,5])

  }

What is the motivation / use case for changing the behavior?

Environment

Nest version: �latest

 
For Tooling issues:
- Node version: 8.9.4  
- Platform:  mac

Others:

[whtiehack]

I think this is a bug. I tried to fix and submit a PR.

[kamilmysliwiec]

Thanks for reporting, I'm on it. 🙂

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.