-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__resolveType is included in enhancers by default #1468
Comments
I'm running into the same issue I think, which I describe in detail here: #1364 (comment) I would love to see this fix merged and released, as then I can get all my transitive graphql dependencies updated - as you might know, multiple versions of graphql in the dependency tree can lead to tricky problems - right now I need to keep my project Vendure pinned to v7.9.7, which means that it does not work with npm v7 since npm v7 by default installs all peerDependencies, as it results in a |
Let's track this here #1469 |
I'm submitting a...
Current behavior
__resolveType
is included in enhancers by default. Additionally, theExecutionContext
that's passed to guards for__resolveType
has incorrect GraphQL args, with info in the slot where context should be, so the methods onGqlExecutionContext
return incorrect values.Expected behavior
Only Queries and Mutations should be included in enhancers by default.
Minimal reproduction of the problem with instructions
https://github.com/timhall/nestjs-resolvetype-issue
Issue was introduced in da4f751 where
__resolveType
used to be covered by the below, but now flows through to the defaults inExternalContextCreator
, which has enhancers enabled by default.Old default:
New default:
https://github.com/nestjs/nest/blob/097afb0884415ee98910d93380b3eb6592cfb03c/packages/core/helpers/external-context-creator.ts#L101
What is the motivation / use case for changing the behavior?
Match previous behavior
Environment
The text was updated successfully, but these errors were encountered: