Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bullmq #720

Closed
wants to merge 2 commits into from
Closed

Migrate to bullmq #720

wants to merge 2 commits into from

Conversation

codetheweb
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Moves to bullmq. Partially resolves #202.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

THe function signatures for job processors have changed slightly. There is no longer a DoneCallback and processors must return a Promise.

Other information

These docs need to be updated: https://docs.nestjs.com/techniques/queues

@sorensenNiels
Copy link

What can we do to get this pr into master and finalize a release

@kevinvdburgt
Copy link

kevinvdburgt commented Apr 13, 2021

What can we do to get this pr into master and finalize a release

It seems that the docs should be updated first.

@kamilmysliwiec any plans to release this migration from bull to bullmq? Or should this become another package as it contains breaking changes?

@sorensenNiels
Copy link

Releasing a bullmq package and later on deprecating the bull package would be great for most. IMHOP.

@tientp-floware
Copy link

Please merge soon, It's very helpful.

@nestjs nestjs locked and limited conversation to collaborators Apr 23, 2021
@kamilmysliwiec
Copy link
Member

As I've mentioned in the past issues, we don't plan to migrate this package to bullmq. Instead, we'll very likely publish a separate module for this (to avoid breaking changes). Locking this PR for the time being to avoid spam (and saving it for future reference).

@kamilmysliwiec
Copy link
Member

#1129

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better API proposal & move to BullMQ
6 participants