Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type def to support property-based injection of @InjectQueue() #2288

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

we will see compilation errors when trying to use @InjectQueue() in a property-based style although this is supported by Inject()

image

export class Foo {
  @InjectQueue('foo')
  private readonly foo: any;
}

What is the new behavior?

as the same as the decorators from @nestjs/typeorm, we can now inject queue via property-based injection

image

Does this PR introduce a breaking change?

  • Yes
  • No

@micalevisk micalevisk changed the title fix: type for support property-based injection of @InjectQueue() fix: type def to support property-based injection of @InjectQueue() Oct 28, 2024
@kamilmysliwiec kamilmysliwiec added the bug Something isn't working label Oct 29, 2024
@kamilmysliwiec kamilmysliwiec merged commit 78105e7 into nestjs:master Oct 29, 2024
1 check passed
@micalevisk micalevisk deleted the patch-1 branch October 29, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants