Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #954: Avoid the use of unrelated typenames to distinguish template classes #956

Merged
merged 2 commits into from
May 14, 2018
Merged

Fix #954: Avoid the use of unrelated typenames to distinguish template classes #956

merged 2 commits into from
May 14, 2018

Conversation

janhahne
Copy link
Contributor

This PR fixes #954 by using the derived class itself as distinguishing template type.
@heplesser and @jakobj could you please have a look?

jakobj
jakobj approved these changes May 13, 2018
View reviewed changes
Copy link
Contributor

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ,that was quick! Maybe use DataType instead of Data for first template, otherwise I am happy! 👍

@terhorstd terhorstd added ZC: Kernel DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL labels May 14, 2018
@terhorstd terhorstd requested a review from jougs May 14, 2018 10:36
jougs
jougs approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jougs jougs merged commit 603090f into nest:master May 14, 2018
@janhahne janhahne deleted the fix954 branch May 28, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@jakobj jakobj jakobj approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Kernel DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using types to distinguish secondary events
4 participants
@janhahne @jakobj @jougs @terhorstd