Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude files starting with ".#" from help generation #802

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Exclude files starting with ".#" from help generation #802

merged 1 commit into from
Aug 7, 2017

Conversation

jakobj
Copy link
Contributor

@jakobj jakobj commented Aug 6, 2017

If these files exist and are not excluded, the help generation fails:

Traceback (most recent call last):                                                                                                              
  File "generate_help.py", line 95, in <module>                                                                                        
    f = open(fname, 'r')                                                                        
FileNotFoundError: [Errno 2] No such file or directory: '/home/jordan/opt/nest-private/nestkernel/.#kernel_manager.cpp'
doc/CMakeFiles/generate_help.dir/build.make:57: recipe for target 'generate_help' failed                                  
make[2]: *** [generate_help] Error 1                                                                                     
CMakeFiles/Makefile2:247: recipe for target 'doc/CMakeFiles/generate_help.dir/all' failed    
make[1]: *** [doc/CMakeFiles/generate_help.dir/all] Error 2                                                                                                                                                                                                                                
make[1]: *** Waiting for unfinished jobs....

This PR fixes this.

@terhorstd terhorstd requested review from heplesser and jougs August 7, 2017 10:17
@terhorstd terhorstd added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL T: Bug Wrong statements in the code or documentation T: Maintenance Work to keep up the quality of the code and documentation. S: High Should be handled next labels Aug 7, 2017
@terhorstd terhorstd added this to the NEST 2.12.1 milestone Aug 7, 2017
heplesser
heplesser requested changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakobj I will approve this as soon as you fix the PEP8 problem and Travis is happy.

@jakobj jakobj force-pushed the bug/exclude_backup_files branch from 7e992f7 to a5ec795 Compare August 7, 2017 11:43
@jakobj
Copy link
Contributor Author

jakobj commented Aug 7, 2017

fixed, rebased and pushed. thanks for the fast review @heplesser

jougs
jougs approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving and merging, although I somehow liked the implicit reminder that I still had unsaved files in emacs when running make ;-)

@jougs jougs merged commit b0ea450 into nest:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobj @heplesser @jougs @terhorstd