Fix execution of MPI-enabled SP tests #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
approved these changes
Aug 4, 2017
There was a problem hiding this comment.
Looks good as a fix for the current issue. I am not really happy, though, with the way in which we here "highjack" the suite() method to run MPI tests. But we can get back to that once we have come to a conclusion on #761.
jougs
added
ZC: Infrastructure
|
Looks good to me, even though there are lines longer than 80. (*.py.in will not run through the PEP8 check) I'm entirely happy with this. Approved! |
gtrensch
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #791 by using the absolute path of the script in the invocation of
python. It also handles skipped tests properly in our custom Python test harness.