Fix issue #678 - Skip help generation without python or python older than 2.7.8 #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using cmake expressions to check for python.
heplesser
requested changes
May 8, 2017
doc/CMakeLists.txt
Outdated
|
|
||
| find_package( PythonInterp ) | ||
| if ( PYTHONINTERP_FOUND ) | ||
| if(${PYTHON_VERSION_STRING} VERSION_GREATER "2.7.7") |
There was a problem hiding this comment.
I think it would be useful to add a comment explaining why we require a version > 2.7.8, including a reference to #678. Also, add spaces around the parenthesis if ( ... ).
heplesser
added
ZC: Installation
|
Confirmed fix for python 3.6 system. |
heplesser
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting python from CMake variables and using this instead of the hard coded python. Skipping help generation if no python is found or the version is older than 2.7.8.
This is a fix for issue #678 and #712