Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point out in documentation that install path should be absolute #701

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Point out in documentation that install path should be absolute #701

merged 1 commit into from
Apr 5, 2017

Conversation

heplesser
Copy link
Contributor

#561 reported some mix-up when passing relative path as install prefix. From Cmake docs, relative paths should be converted to absolute automatically, but to be safe I added explicit remarks to the installation instructions.

As single reviewer should suffice on this one.

@heplesser heplesser added ZC: Installation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Apr 4, 2017
@heplesser heplesser requested a review from mschmidt87 April 4, 2017 09:54
@heplesser heplesser merged commit 2600496 into nest:master Apr 5, 2017
@heplesser heplesser deleted the fix-561-absolute-path-doc branch May 26, 2017 12:02
@jougs jougs changed the title Point out in documentation that install path should be absolute, fixes #561 [ci skip] Point out in documentation that install path should be absolute Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschmidt87 mschmidt87 mschmidt87 approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heplesser @mschmidt87