Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set current NEST version to '3.0.0-SNAPSHOT'. #448

Merged
merged 4 commits into from
Aug 26, 2016

Conversation

DimitriPlotnikov
Copy link

@DimitriPlotnikov DimitriPlotnikov commented Aug 4, 2016

The version number for the NEST Head in the repo until the next release will be 2.11

…lem that outdated version was printed after executing 'nest' binary.
@@ -6,7 +6,7 @@

# default value, if git is not installed or if the source directory is
# not under version control
version="v2.10.0"
version="v3.1.0-SNAPSHOT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be v3.0.0-SNAPSHOT? And wouldn't it be better to build this string automatically from NEST_VERSION_VERSION defined in CMakeLists.txt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, making a file-creator script creator. Sounds complex. I guess it could grep out of config.h as well, or use a c preprocessor to extract it. A bit complex as well. Maybe source a very small file that does the version definition made by cmake?

Or maybe just stick this all in cmake and just add an operator that pulls it from config.h?

Tracking version control information inside of projects is always painful, and I tend to think not so useful without the build infrastructure, and if you have the build infrastructure, you already have that information in the tree.

Maybe we only want to track "Is this release version X" or "You built this yourself, you should know how to give us the hash"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://xit0.org/2013/04/cmake-use-git-branch-and-commit-details-in-project/

That could simplify (eliminate) all this code, if we really want to insert the hashes in sli; on the other hand, inserting it in sli instead of c defeats the goal of making a complete and clear c api.

@heplesser
Copy link
Contributor

In principle ok, provided my inline comments are addressed.

@jougs @apeyser @mschmidt87 What to you think?

@apeyser
Copy link
Contributor

apeyser commented Aug 5, 2016

@heplesser

As per issue #411 , I'd suggest we go to even/odd numbering. It's not a big deal, but if we go with -SNAPSHOT, immediately at the time of a release, we have to commit to whether the next release is a big release or a small release. We don't have an option without confusing ourselves about what's going on.

We've already had this happen with 3.0, with discussion after 2.8 whether the next release was a 2.x or a 3.0.

@heplesser
Copy link
Contributor

@apeyser I agree with you in principle. My thought right now was that 3.0 is going to be the next big one, so we could use this patch as a temporary fix and then define a long term policy in our meeting in two weeks. But we might as well wait two+ weeks and then fix it for real.

@apeyser
Copy link
Contributor

apeyser commented Aug 5, 2016

@heplesser Then we should accept, if the decision is fixed that we definitely will not be putting out any other major revision than 3.0. No practical consequence. Then afterwards, we can decide.

@terhorstd
Copy link
Contributor

I would agree to apeyser that we don't initially want to commit ourselves to the upcomming version number. What about first sorting the current issues to milestones and then actually planning the versions a bit more in advance? I don't see a reason why there shouldn't be a 2.12 and a 3.0 milestone in parallel. We could properly sort the issues with major changes to the new major version and the others to 2.12.

@heplesser
Copy link
Contributor

We decided in the Open NEST Developer VC today that we will use odd minor version numbers numbers for NEST in between releases, with no further detailing. Thus, the version number for the NEST Head in the repo until the next release will be 2.11.

We may create -RC version numbers on release branches shortly before a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants