Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Jupyter notebook download to examples and move script to _ext folder #2903

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Aug 23, 2023

This PR cleans up the conf.py a bit by moving the 80ish lines of code (function that adds the buttons that launch the Jupyter service in the examples docs) into the _ext folder.

It also re-adds the download of Jupyter notebooks directly from the example page as requested by @akorgor

For example no change to the 'try it on ebrains' button, and notebook download is readded to bottom of page:
https://nest-simulator--2903.org.readthedocs.build/en/2903/auto_examples/brunel_alpha_nest.html

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 23, 2023
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@jessica-mitchell jessica-mitchell removed the request for review from terhorstd September 11, 2023 11:07
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@jessica-mitchell jessica-mitchell merged commit 50403ee into nest:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants