Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit typo #2839

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix unit typo #2839

merged 1 commit into from
Jun 27, 2023

Conversation

anthropikos
Copy link
Contributor

The rate parameter should be in Hz instead of pA.

The rate parameter is indicated as Hz a few lines down with the function to convert the units of rate to fit the simulation resolution (ms).

@anthropikos
Suggest unit change
0c17708 
The rate parameter should be in Hz instead of pA.

The rate parameter is indicated as Hz a few lines down with the function to convert the units of rate to fit the simulation resolution (ms).
clinssen
clinssen approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@terhorstd terhorstd changed the title Suggest unit change Fix unit typo Jun 27, 2023
@terhorstd terhorstd merged commit 54faff3 into nest:master Jun 27, 2023
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthropikos @clinssen @terhorstd