Add rectified Gabor distribution for nest.spatial #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Enhancement
heplesser
requested changes
May 6, 2022
There was a problem hiding this comment.
@ackurth Thank you for this addition. Given the wide use of Gabors it does seem sensible to have support for them at the C++-level. Could you maybe also add an example? See #2388 (comment) concerning the parameterization.
|
I suggest we wait a bit with this one until we have discussed #2391. |
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
terhorstd
added
the
P: Blocked
|
@heplesser & @ackurth any news regarding this PR and the issue #2391 |
github-actions
bot
removed
the
stale
|
@heplesser & @ackurth any news regarding this PR? |
heplesser
removed
the
P: Blocked
|
@ackurth Could you check the remaining code-formatting issues? |
terhorstd
reviewed
Aug 28, 2023
terhorstd
reviewed
Aug 28, 2023
JoseJVS
reviewed
Aug 28, 2023
terhorstd
reviewed
Aug 28, 2023
JoseJVS
reviewed
Aug 28, 2023
JoseJVS
reviewed
Aug 28, 2023
JoseJVS
reviewed
Aug 28, 2023
Co-authored-by: Jose Villamar <[email protected]>
terhorstd
reviewed
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
nest.spatial_distributionsfunctions to generate a spatial connectivity profile with probabilities described by a Gabor function (see here).While in principle it seems to be possible to obtain the same functionality with other build in
nestfunctions, this would, to my understanding, be rather cumbersome. Therefore I think that it might be worthwhile to add this function toneston this level.Note that the parametrization used for the two-dimensional Gaussian differs from the one of
nest.spatial_distributions.gaussian2D.I think the parametrization used in this PR is more intuitive and could be used also for this function (see #2388).