-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement recording of signals provided by stimulating devices #658
Comments
I think I have managed to implement the record feature for the AC current source. The modified files are here (not yet ready for a pull): A sample output for the code here: @heplesser : It would be great if you could take a look before I move on to the other models. Some of the queries I had were:
insert_( Name( names::amplitude ), &ac_generator::get_inj_ ); and had to use one of the existing names in the context (e.g. amplitude, phase). I went ahead with 'amplitude' here, but a different name (such as i_inj) would be more appropriate.
This is the first time I have used the nest simulator in any capacity, and so apologies if I have made any noobie mistakes. |
I think I have solved my first query by adding: Changes would accordingly be made in ac_generator files, such as: insert_( Name( names::amplitude ), &ac_generator::get_inj_ ); changed to: insert_( Name( names::I_inj ), &ac_generator::get_I_inj_ ); and renaming the earlier variable inj_ with I_inj_ throughout (for better readability) |
@appukuttan-shailesh Your code looks quite fine, but it seems you are working on the basis of NEST 2.10. Please use the most recent code from Github as the basis of any development to minimize the risk of merge conflicts later. You don't seem to have added unnecessary code. Names are a complex matter. One purpose of the insert_( names::I ), &ac_generator::get_I_ ): The comment "specific to Mirollo-Strogatz" on Data is first buffered in the |
Thanks for pointing that out. I have now updated my repository to the latest version, and made the necessary changes. I have implemented the record feature for the following models:
A sample output for the above (code): I shall initiate a pull request so that you can review the changes. |
Fixes #658: Implements recording of current generated by stimulating devices
This query was originally intended towards the development of the PyNN-NEST interface, but has a more general application within NEST. The objective was to record the profile of injected current, but:
@heplesser informed me that this would require small additions to the model, but could be achieved. I plan to look into this, and shall update here if I make any progress.
The text was updated successfully, but these errors were encountered: