Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make installcheck fails when building with -DNDEBUG #272

Closed
tammoippen opened this issue Mar 10, 2016 · 0 comments · Fixed by #770
Closed

make installcheck fails when building with -DNDEBUG #272

tammoippen opened this issue Mar 10, 2016 · 0 comments · Fixed by #770
Assignees
@jougs
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: In progess DO NOT USE THIS LABEL

Comments

@tammoippen
Copy link
Contributor

Enabling the flag NDEBUG breaks make installcheck, as we relay on assertions to fail in the test selftests/test_crash_or_die.sli (when building without mpi). All other tests seem to pass.

The CMAKE_BUILD_TYPE [1] (#213) system usually sets this flag for everything beyond Debug, but has some advantages.
@heplesser heplesser added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) I: User Interface Users may need to change their code due to changes in function calls ZP: In progess DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jun 29, 2017
jougs added a commit to jougs/nest-simulator that referenced this issue Jun 29, 2017
@jougs
Skip test if NDEBUG is set. This fixes nest#272.
4301150
@jougs jougs mentioned this issue Jun 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jougs jougs

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: In progess DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip test if NDEBUG is set jougs/nest-simulator
3 participants
@heplesser @jougs @tammoippen