Fixed #35667 -- Improved deprecation warning handling by replacing stacklevel with skip_file_prefixes. #18
Conversation
…acklevel with skip_file_prefixes. Signed-off-by: saJaeHyukc <[email protected]>
nessita
force-pushed
the
pr/18683-nessita
branch
from
ac51558 to
6bf2739
Compare
| caller_frame = inspect.stack()[1] | ||
| caller_file = caller_frame.frame.f_globals.get("__file__", None) | ||
| kwargs = {"skip_file_prefixes": (os.path.dirname(caller_file),)} |
There was a problem hiding this comment.
I don't think that's what we want and I suspect some tests will fail. What this does is retrieve the package of the caller and pass it as skip_file_prefixes but this doesn't account for user code indirectly calling into a nested package emitting a warning.
As an example, think of a method in django.db.models.sql.query that emit a warnings when called with a particular signature that is used by a public interface in django.db.models. When user code calls into the public interface exposed by the public interface we want the deprecation warning to be raised at the user call site and not at django.db.models proxy call site.
The code above would make it so skip_file_prefixes = (os.path.dirname(django.db.models.sql.__file__),) which bakes the assumption that we'll always emit warnings one package away from publicly exposed interfaces.
To put it simply I think we should simply set skip_file_prefixes=(os.path.dirname(django.__file__),) systmetically on PY312 once we've confirmed that we don't make use of the deprecated code internally and do away with the stacklevel arithmetic.
Trac ticket number
ticket-35667