Use debug.traceback for stack traces in Lua-based carts. #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fennel carts have debug.traceback set to fennel.traceback during initialization, which is a function that uses sourcemaps to convert the traceback data which Lua knows about (with line numbers based on the Lua output from the Fennel compiler) into traceback data based on line numbers in the original source code. Previously this had no effect because debug.traceback was never actually run; luaapi.c contained a call to the underlying luaL_traceback function instead, which did not know about sourcemaps. Replacing it with a call to debug.traceback allows us to see stack traces that use sourcemap data. This change should have no effect on Lua carts; only Fennel carts and perhaps Moonscript carts. Also in this patch we set the filename field when compiling Fennel carts; without this the custom fennel.traceback function can't use sourcemaps as needed.
nesbox
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fennel carts have debug.traceback set to fennel.traceback during initialization, which is a function that uses sourcemaps to convert the traceback data which Lua knows about (with line numbers based on the Lua output from the Fennel compiler) into traceback data based on line numbers in the original source code.
Previously this had no effect because debug.traceback was never actually run; luaapi.c contained a call to the underlying luaL_traceback function instead, which did not know about sourcemaps. Replacing it with a call to debug.traceback allows us to see stack traces that use sourcemap data.
This change should have no effect on Lua carts; only Fennel carts and perhaps Moonscript carts.
Also in this patch we set the filename field when compiling Fennel carts; without this the custom fennel.traceback function can't use sourcemaps as needed.