Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase in possible notes for playing on piano roll, new keyboard layout (like in popular DAWs) #2336

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

jejikeh
Copy link
Contributor

@jejikeh jejikeh commented Oct 24, 2023

Slightly changed the keyboard in the SFX editor so that it became more similar to the popular DAWs (Ableton, Garage Band, etc...)

  1. Added the ability to switch between octaves on Z and X
  2. Raised all the shortcuts one row higher (A, W, S, E, D, ...)
  3. Increase the number of possible notes that can be played on the keyboard

…s. Added keyboard shortcuts for switching between octaves.
@Skeptim
Copy link
Contributor

Skeptim commented Oct 24, 2023

The same hotkeys apply on the tracker mode of the music editor. Are they both affected? They should be consistent.

@jejikeh
Copy link
Contributor Author

jejikeh commented Oct 24, 2023

I completely forgot about it :) I'll fix it soon

… range of playable notes. Added shortcuts to change the octave.
@jejikeh
Copy link
Contributor Author

jejikeh commented Oct 24, 2023

I added support for playing on the second octave in SFX piano roll as well as in Music Editor. Added shortcuts to change the octave.

  1. To play on 1 octave use: Z../
  2. To play on 2 octave use: Q..P
  3. To change octave press: shift+z or shift+x

@Skeptim
Copy link
Contributor

Skeptim commented Oct 25, 2023

I came across this today: #722
That could be an issue to check before merging, or in the other way, your pull request could solve it.

@jejikeh
Copy link
Contributor Author

jejikeh commented Oct 25, 2023

Since in the SFX editor you can play notes by holding the keys, the note C# is played if you release ctrl before S.

This can be fixed, but I'm afraid that the code will not be very good :\

@nesbox nesbox merged commit 1b0b9e0 into nesbox:main Nov 3, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants