[0019] doc: Add data structure doc which also captures latest script refactoring changes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc included here is directly imported from https://github.com/nervosnetwork/ckb/blob/b5d78df252188a5e3675f8202432bd620c000876/docs/data-structures.md
8 tasks
Mine77
suggested changes
Mar 26, 2019
|
Also do you need to update the readme of the repo as well? |
Will do this once @doitian approves this and assigns an RFC number. |
Mine77
approved these changes
Mar 26, 2019
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Mar 27, 2019
344: refactor: Revise script structure r=doitian a=xxuejie * [x] rfc changes: nervosnetwork/rfcs#91 * [x] ckb-system-scripts: nervosnetwork/ckb-system-scripts#2 * [x] mruby-contracts: nervosnetwork/mruby-contracts#7 * [x] ruby sdk: nervosnetwork/ckb-demo-ruby#76 * [x] ruby scripts: nervosnetwork/ckb-ruby-scripts#9 * [ ] swift sdk * [ ] java sdk * [ ] js sdk --- This is a **BREAKING CHANGE**. Co-authored-by: Xuejie Xiao <[email protected]>
janx
requested changes
Mar 27, 2019
Updated. |
doitian
changed the title
doitian
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Mar 28, 2019
doitian
approved these changes
Mar 28, 2019
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Mar 28, 2019
344: refactor: Revise script structure r=xxuejie a=xxuejie * [x] rfc changes: nervosnetwork/rfcs#91 * [x] ckb-system-scripts: nervosnetwork/ckb-system-scripts#2 * [x] mruby-contracts: nervosnetwork/mruby-contracts#7 * [x] ruby sdk: nervosnetwork/ckb-demo-ruby#76 * [x] ruby scripts: nervosnetwork/ckb-ruby-scripts#9 * [ ] swift sdk * [ ] java sdk * [ ] js sdk --- This is a **BREAKING CHANGE**. Co-authored-by: Xuejie Xiao <[email protected]>
janx
requested changes
Mar 29, 2019
u2
suggested changes
Apr 3, 2019
u2
approved these changes
Apr 3, 2019
doitian
requested changes
Apr 8, 2019
There was a problem hiding this comment.
Please cp the change to remove cellbase here nervosnetwork/ckb@528e95e#diff-9cec9a07c6273e16f3fbf77943c66196 to avoid another PR.
1 task
This is done now |
doitian
approved these changes
Apr 8, 2019
janx
requested changes
Apr 8, 2019
Co-Authored-By: xxuejie <[email protected]>
Co-Authored-By: xxuejie <[email protected]>
Co-Authored-By: xxuejie <[email protected]>
janx
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nervosnetwork/ckb#344