Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Omnilock #343

Merged
merged 23 commits into from
Jul 19, 2022
Merged

RFC: Omnilock #343

merged 23 commits into from
Jul 19, 2022

Conversation

XuJiandong
Copy link
Contributor

No description provided.

@XuJiandong XuJiandong mentioned this pull request May 25, 2022
14 tasks
rfcs/0000-omnilock/0000-omnilock.md Outdated Show resolved Hide resolved
rfcs/0000-omnilock/0000-omnilock.md Outdated Show resolved Hide resolved
@XuJiandong XuJiandong marked this pull request as ready for review June 9, 2022 01:19
@XuJiandong XuJiandong requested a review from a team as a code owner June 9, 2022 01:19
@XuJiandong XuJiandong requested a review from knwang June 9, 2022 01:19
Copy link
Member

@janx janx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I walked through the open section and removed decorative words to make the RFC more concise. Some paragraphs may need reformat.

rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Outdated Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Show resolved Hide resolved
rfcs/0042-omnilock/0042-omnilock.md Show resolved Hide resolved
quake
quake previously approved these changes Jul 13, 2022
@janx janx requested review from janx and removed request for knwang July 13, 2022 07:31
janx
janx previously approved these changes Jul 13, 2022
zhangsoledad
zhangsoledad previously approved these changes Jul 15, 2022
@XuJiandong XuJiandong dismissed stale reviews from zhangsoledad, janx, and quake via e2c1c2f July 18, 2022 01:31
@janx janx merged commit 31e4679 into nervosnetwork:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants