Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the current problematic ESLint and Prettier workflow #2662

Merged
merged 12 commits into from
May 16, 2023

Conversation

WhiteMinds
Copy link
Contributor

Fix the current problematic ESLint and Prettier workflow

.createHmac('sha512', Buffer.from('Bitcoin seed', 'utf8'))
.update(seed)
.digest()
const i = crypto.createHmac('sha512', Buffer.from('Bitcoin seed', 'utf8')).update(seed).digest()

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bitcoin seed" is used as [key](1).
.vscode/extensions.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
packages/neuron-ui/.prettierrc.js Show resolved Hide resolved
packages/neuron-wallet/.prettierrc.js Outdated Show resolved Hide resolved
@WhiteMinds WhiteMinds force-pushed the fix/143_CodeStyle branch 4 times, most recently from 23a2f78 to 66deb97 Compare May 16, 2023 04:09
@WhiteMinds
Copy link
Contributor Author

Rebased onto develop branch.

@Keith-CY Keith-CY merged commit 0367857 into nervosnetwork:develop May 16, 2023
@WhiteMinds WhiteMinds deleted the fix/143_CodeStyle branch May 26, 2023 07:28
@Keith-CY Keith-CY mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants