fix: Add min-height avoid dialog truncation #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yanguoyu
commented
May 10, 2023
yanguoyu
commented
- before the change
- after the change
|
Seems that the modal is not 100% full of the width and height |
Because this main page https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-ui/src/containers/Main/index.tsx#L188 is not 100% height, If we change the main page to 100%, we may need to check other functions. |
Reasonable |
Keith-CY
approved these changes
May 10, 2023
alexsupa597
approved these changes
May 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.