Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: new UI nav menu #2513

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Feat: new UI nav menu #2513

merged 3 commits into from
Nov 1, 2022

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Oct 25, 2022 •
edited
Loading

image

image

image

image

@yanguoyu yanguoyu mentioned this pull request Oct 25, 2022
Closed
3 tasks
@yanguoyu
Copy link
Collaborator Author

I have a little query about the expansion menu, so expand menu does not finish yet.

@Cedar67
Copy link
Contributor

Cedar67 commented Oct 25, 2022

The Chinese copy here needs to be confirmed or modified.

image

@Keith-CY
Copy link
Collaborator

The Chinese copy here needs to be confirmed or modified.

image

Pick 实验性/experimental which is used in the production version now.

@Cedar67
Copy link
Contributor

Cedar67 commented Oct 25, 2022

Pick 实验性/experimental which is used in the production version now.

ok. The Figma UI design Copy needs to be modified.

@Cedar67
Copy link
Contributor

Cedar67 commented Oct 26, 2022

The current wallet name is abnormal when it is too long.

image

@Cedar67
Copy link
Contributor

Cedar67 commented Oct 26, 2022

The font on the right of the image below is recommended.

image

@yanguoyu
Copy link
Collaborator Author

The font on the right of the image below is recommended.

image

These fonts should be system default

@Cedar67
Copy link
Contributor

Cedar67 commented Oct 26, 2022

These fonts should be system default

ok, just follow this rule.

@yanguoyu yanguoyu marked this pull request as draft October 28, 2022 06:17
@yanguoyu
Copy link
Collaborator Author

The current wallet name is abnormal when it is too long.

image

Fixed and add expand menu.

@yanguoyu yanguoyu marked this pull request as ready for review October 28, 2022 12:47
@Cedar67
Copy link
Contributor

Cedar67 commented Nov 1, 2022 •
edited
Loading

The current wallet name is abnormal when it is too long.
image

Fixed and add expand menu.

Verified.

image

image

Cedar67
Cedar67 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function and user experience are both verified.

@Keith-CY Keith-CY merged commit 9435681 into nervosnetwork:new-ui-design Nov 1, 2022
@yanguoyu yanguoyu deleted the feat-new-ui-nav branch November 2, 2022 01:11
@Keith-CY Keith-CY mentioned this pull request Feb 23, 2023
Closed
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 10, 2023
@yanguoyu
Feat: new UI nav menu (nervosnetwork#2513)
b92d453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cedar67 Cedar67 Cedar67 approved these changes

@alexsupa597 alexsupa597 alexsupa597 approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanguoyu @Cedar67 @Keith-CY @alexsupa597