feat(neuron-ui): remove input truncation on importing keystore. (#1068)

* feat(neuron-ui): remove input truncation on importing keystore. * refactor(neuron-ui): hide the password in error message
nervosnetwork · Nov 11, 2019 · 2d6283d · 2d6283d
1 parent 8686707
commit 2d6283d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/packages/neuron-ui/src/components/ImportKeystore/index.tsx b/packages/neuron-ui/src/components/ImportKeystore/index.tsx
@@ -98,7 +98,6 @@ const ImportKeystore = (props: React.PropsWithoutRef<StateWithDispatch & RouteCo
               placeholder={t(`import-keystore.placeholder.${key}`)}
               type={key === 'password' ? 'password' : 'text'}
               readOnly={key === 'path'}
-              maxLength={maxLength}
               value={value}
               validateOnLoad={false}
               onGetErrorMessage={(text?: string) => {
@@ -108,6 +107,13 @@ const ImportKeystore = (props: React.PropsWithoutRef<StateWithDispatch & RouteCo
                 if (key === 'name' && isNameUsed) {
                   return t(`messages.codes.${ErrorCode.FieldUsed}`, { fieldName: `name`, fieldValue: text })
                 }
+                if (text && maxLength && text.length > maxLength) {
+                  return t(`messages.codes.${ErrorCode.FieldTooLong}`, {
+                    fieldName: key,
+                    fieldValue: key === 'password' ? '' : text,
+                    length: maxLength,
+                  })
+                }
                 return ''
               }}
               onChange={(_e: React.FormEvent<HTMLInputElement | HTMLTextAreaElement>, newValue?: string) => {

diff --git a/packages/neuron-ui/src/locales/en.json b/packages/neuron-ui/src/locales/en.json
@@ -259,6 +259,7 @@
       "fields": {
         "wallet": "Wallet",
         "name": "Name",
+        "password": "Password",
         "remote": "RPC URL",
         "network": "Network",
         "address": "Address",

diff --git a/packages/neuron-ui/src/locales/zh.json b/packages/neuron-ui/src/locales/zh.json
@@ -259,6 +259,7 @@
       "fields": {
         "wallet": "钱包",
         "name": "名称",
+        "password": "密码",
         "remote": "RPC URL",
         "network": "网络",
         "address": "地址",