Fix channel amount and fee issues #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
changed the title
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
4 times, most recently
from
e1147ad
to
5b09c5a
Compare
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
dfd194f
to
4970fcd
Compare
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
5c916cf
to
5de7bb2
Compare
chenyukang
changed the title
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
5de7bb2
to
9b35102
Compare
doitian
reviewed
Jun 24, 2024
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
d88bb40
to
7ad3984
Compare
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
6 times, most recently
from
8bb4b54
to
b39b2de
Compare
doitian
reviewed
Jun 25, 2024
| @@ -180,6 +181,7 @@ pub enum NetworkActorEvent { | |||
| Option<Script>, | |||
| u64, | |||
| u64, | |||
| u64, | |||
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
b39b2de
to
3ca56d1
Compare
doitian
reviewed
Jun 25, 2024
contrun
reviewed
Jun 25, 2024
| // The commitment fee rate is used to calculate the fee for the commitment transactions. | ||
| // The side who starting a shutdown command need to pay at least this fee for building shutdown transaction, | ||
| // the other side may choose to pay less fee rate if the current fee is enough. | ||
| pub commitment_fee_rate: u64, |
There was a problem hiding this comment.
The name commitment_fee_rate and the comment is not consistent. Why is commitment_fee_rate named commitment_fee_rate although it is used only in the shutdown transaction?
There was a problem hiding this comment.
commitment_fee_rate will also be used in commitment transaction (I will add it later, I haven't determined which party pay the fee or both parties pay the fee), we treat shutdown transaction is a special commitment transaction.
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
4addac3
to
00a0657
Compare
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
00a0657
to
f278ccb
Compare
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
fa5c985
to
6327598
Compare
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
6327598
to
eb43c8b
Compare
quake
reviewed
Jun 26, 2024
| @@ -152,11 +129,17 @@ impl TxBuilder for FundingTxBuilder { | |||
| None => packed::Transaction::default().as_advanced_builder(), | |||
| }; | |||
|
|
|||
| // set a placeholder_witness for calculating transaction fee according to transaction size | |||
| let placeholder_witness = packed::WitnessArgs::new_builder() | |||
| .lock(Some(molecule::bytes::Bytes::from(vec![0u8; 170])).pack()) | |||
There was a problem hiding this comment.
How did this hard-coded 170 come about?
chenyukang
force-pushed
the
fix-channel-amount-issues
branch
from
91fff7d
to
e3ce52f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes:
ckbamount andfeerelated fields fromu128tou64commitment_fee_ratein open channel rpcfee_rateinstead of fee in the shutdown command, and verify shutdown fee is valid when handing shutdown commandlocal_reserve_ckb_amountandremote_reserve_ckb_amountto make sure we can always build valid commitment tx or shutdown tx.funding_fee_rateoption to specify and calculate the fee in funding transaction.