feat: auto accept channel #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
approved these changes
Jun 12, 2024
| name = "CKB_OPEN_CHANNEL_MIN_CKB_FUNDING_AMOUNT", | ||
| long = "ckb-open-channel-min-ckb-funding-amount", | ||
| env, | ||
| help = "minimum ckb funding amount for open channel requests, unit: shannons [default: 16100000000 shannons]" |
There was a problem hiding this comment.
Can we define a constant for the default value 16100000000 so that we can keep various references to this value in sync?
| @@ -1061,6 +1061,11 @@ enum CommitmentSignedFlags { | |||
| } | |||
|
|
|||
| #[derive(Copy, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | |||
| #[serde( | |||
There was a problem hiding this comment.
What is the purpose of this change?
There was a problem hiding this comment.
What is the purpose of this change?
to unify the json format of the output, for example:
"state": {
"state_name": "SIGNING_COMMITMENT",
"state_flags": "OUR_COMMITMENT_SIGNED_SENT | THEIR_COMMITMENT_SIGNED_SENT"
}|
|
||
| fn get_channel_states(&self, peer_id: Option<PeerId>) -> Vec<(PeerId, Hash256, ChannelState)> { | ||
| let prefix = match peer_id { | ||
| Some(peer_id) => [&[64], peer_id.as_bytes()].concat(), |
There was a problem hiding this comment.
Can use define a constant for the prefix 64 and refer to that constant instead of directly using the literal 64?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.