Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing features for tokio #4716

Merged

Conversation

doitian
Copy link
Member

@doitian doitian commented Nov 18, 2024

What problem does this PR solve?

Problem Summary: Failed to publish ckb-script because of the missing features.

What is changed and how it works?

What's Changed: Add missing features of "tokio" in the Cargo.toml of ckb-script

Check List

Tests

  • Integration test
  • Manual test
    cargo publish in directory script/.

Release note

None: Exclude this PR from the release note.

@doitian doitian requested a review from a team as a code owner November 18, 2024 02:13
@doitian doitian requested review from quake and removed request for a team November 18, 2024 02:13
@doitian doitian changed the title fix: add missing features sync for tokio fix: add missing features for tokio Nov 18, 2024
@doitian doitian marked this pull request as draft November 18, 2024 02:33
quake
quake previously approved these changes Nov 18, 2024
- sync for `tokio::sync`
- macros for `tokio::select`
@doitian doitian force-pushed the fix-cargo-deps-missing-features branch from a073315 to 8c05ab2 Compare November 18, 2024 02:35
@doitian doitian marked this pull request as ready for review November 19, 2024 01:34
@doitian doitian requested a review from quake November 19, 2024 01:34
@doitian doitian added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@doitian doitian added this pull request to the merge queue Nov 19, 2024
Merged via the queue into nervosnetwork:develop with commit fdc3a50 Nov 19, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants