fix(script): fixed panic when calling inherited_fds in root process #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
approved these changes
Oct 15, 2024
zhangsoledad
approved these changes
Oct 16, 2024
zhangsoledad
added a commit
to zhangsoledad/ckb
that referenced
this pull request
Oct 16, 2024
fix(script): fixed panic when calling inherited_fds in root process
zhangsoledad
added a commit
that referenced
this pull request
Oct 16, 2024
Backport #4679, fix(script): fixed panic when calling inherited_fds in root process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When
inherited_fds()is called in the root process, vm will panic.What is changed and how it works?
What's Changed:
Returns an empty vector directly when
inherited_fds()is called in the root process.Check List
Tests
Release note