Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #4512" #4672

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Revert "Merge pull request #4512" #4672

merged 2 commits into from
Oct 9, 2024

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Oct 9, 2024 •
edited
Loading

What problem does this PR solve?

Regarding the incompatible update introduced in #4512, to avoid extensive modifications for developers using ckb-types, we have decided to temporarily revert this PR. Although we have developed the ckb-gen-type-migrate tool to assist developers with the migration and upgrade process, this tool is still in its development and testing stages and is not yet fully mature. To prevent any inconvenience for developers, we will reintroduce this improvement once the tool is stable.

This process will include:

  • Reverting the feat: Impl from into for gen type #4512 PR: Ensuring that the current version does not introduce incompatible updates.
  • Continuing to improve the migration tool: Further developing and thoroughly testing ckb-gen-type-migrate to ensure it can reliably and efficiently assist developers with migration.
  • Reintroducing the improvement: Once the tool is fully developed, we will reintroduce this improvement and provide guidance to developers on how to smoothly upgrade using the migration tool.

This approach is to ensure that the upgrade process is smoother for developers, minimizing unnecessary code changes and maintenance overhead.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None: Exclude this PR from the release note.

@zhangsoledad zhangsoledad marked this pull request as ready for review October 9, 2024 02:23
@zhangsoledad zhangsoledad requested a review from a team as a code owner October 9, 2024 02:23
@zhangsoledad zhangsoledad requested review from doitian and removed request for a team October 9, 2024 02:23
doitian
doitian previously approved these changes Oct 9, 2024
View reviewed changes
@zhangsoledad
Revert "Merge pull request #4512 from driftluo/impl-from-into-for-gen…
9f170f6 
…-type"

This reverts commit 18c68f5, reversing
changes made to 0274984.
@quake quake added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit d49cd4e Oct 9, 2024
33 checks passed
@zhangsoledad zhangsoledad deleted the zhangsoledad/revert-gen-type branch October 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@driftluo driftluo driftluo approved these changes

@quake quake Awaiting requested review from quake

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangsoledad @doitian @driftluo @eval-exec @quake