Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] merge several fixes into 118 for next rc release #4616

Closed
wants to merge 45 commits into from

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Backport: #4605, #4600, #4606, #4612, #4615

chenyukang and others added 18 commits August 12, 2024 21:08
Integration Test: wait find unverified blocks finish for all specs
Fix SendLargeCyclesTxToRelay spec on slow machine
chore(test): Fix the unstable spec ForksContainSameUncle caused by block hash collision
Fix: verify worker exit when signal_exit is_cancelled
chore(RPC): add PRC to clear verify queue
…ockFetchCMD-dropped

Do not start `BlockDownload` thread if ckb has received exit signal
@chenyukang chenyukang requested a review from a team as a code owner August 27, 2024 02:29
doitian
doitian previously approved these changes Aug 28, 2024
Integration Test: do not kill gracefully on windows
driftluo and others added 4 commits August 29, 2024 14:59
Integration Test: restart node if it failed to start in `RandomlyKill`
fix: fix atomic ordering in multi-thread
@eval-exec
Copy link
Collaborator

Wait #4623

Copy link
Collaborator

@eval-exec eval-exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to merge develop into rc/v0.118.x, but the GitHub merge rules for ckb prevent merging when the PR branch (develop) is not based on rc/v0.118.x. Additionally, we can't rebase develop onto rc/v0.118.x.

I suggest closing this PR, creating a new branch from develop (e.g., backport/develop), rebasing backport/develop onto rc/v0.118.x, and then submitting a new PR to merge backport/develop into rc/v0.118.x.

@chenyukang chenyukang closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants