Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PoolRpc::test_tx_pool_accept, check if the transaction can be accepted by TxPool #4433

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add PoolRpc::test_tx_pool_accept, check if the transaction can be accepted by TxPool #4433

merged 1 commit into from
Apr 24, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 23, 2024 •
edited
Loading

What problem does this PR solve?

Returns the result of transaction pool acceptance tests, indicating whether the raw transaction would be accepted by the transaction pool. The transaction will not be inserted into the transaction pool.

Related changes

  • Add test_tx_pool_accept for PoolRpc

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec changed the title [WIP] PoolRPC::test_tx_pool_accept RPC Add PoolRpc::test_tx_pool_accept to test Apr 23, 2024
@eval-exec eval-exec changed the title Add PoolRpc::test_tx_pool_accept to test Add PoolRpc::test_tx_pool_accept, check if the transaction can be accepted by TxPool Apr 23, 2024
@eval-exec eval-exec marked this pull request as ready for review April 23, 2024 04:33
@eval-exec eval-exec requested a review from a team as a code owner April 23, 2024 04:33
@eval-exec eval-exec added the b:rpc Break RPC interface label Apr 23, 2024
quake
quake previously approved these changes Apr 24, 2024
View reviewed changes
@eval-exec
Copy link
Collaborator Author

eval-exec commented Apr 24, 2024 •
edited
Loading

Squash and rebased on develop.

@quake quake enabled auto-merge April 24, 2024 02:15
@quake quake added this pull request to the merge queue Apr 24, 2024
Merged via the queue into nervosnetwork:develop with commit 410890c Apr 24, 2024
32 checks passed
@eval-exec eval-exec mentioned this pull request Apr 24, 2024
Closed
This was referenced Apr 25, 2024
Closed
Closed
@zhangsoledad zhangsoledad mentioned this pull request Apr 26, 2024
Open
@15168316096 15168316096 mentioned this pull request Apr 30, 2024
Merged
8 tasks
@homura homura mentioned this pull request May 14, 2024
Open
@doitian doitian mentioned this pull request Jun 4, 2024
Closed
@homura homura mentioned this pull request Jun 4, 2024
Open
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake quake left review comments

@chenyukang chenyukang Awaiting requested review from chenyukang

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
b:rpc Break RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @doitian