Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgade rust-toolchain to 1.75.0 #4356

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Upgade rust-toolchain to 1.75.0 #4356

merged 10 commits into from
Mar 6, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Require: nervosnetwork/ckb-docker-builder#28

It's time we updated our rust-toolchain. It's been five months since our last update.
What's Changed:

Related changes

  • Upgrade rust-toolchain to 1.75.0
  • Pin clap version to 4.4

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/upgrade-toolchai-to-1.75.0 branch from c3c73e1 to 4d90054 Compare February 20, 2024 03:05
@eval-exec eval-exec marked this pull request as ready for review February 20, 2024 03:08
@eval-exec eval-exec requested a review from a team as a code owner February 20, 2024 03:08
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team February 20, 2024 03:08
@eval-exec eval-exec mentioned this pull request Feb 20, 2024
Closed
driftluo
driftluo previously approved these changes Feb 20, 2024
View reviewed changes
doitian
doitian previously approved these changes Mar 5, 2024
View reviewed changes
@doitian
Copy link
Member

doitian commented Mar 5, 2024

Docker Images are on the way: https://github.com/nervosnetwork/ckb-docker-builder/actions/runs/8152714530

@doitian doitian added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@eval-exec
Copy link
Collaborator Author

Fixing ci errors..

@eval-exec eval-exec force-pushed the exec/upgrade-toolchai-to-1.75.0 branch from 395d18c to 89a32bf Compare March 5, 2024 14:52
@eval-exec eval-exec dismissed stale reviews from driftluo and doitian via 1e507c9 March 5, 2024 14:56
@eval-exec
Copy link
Collaborator Author

I just rebased develop, and regenerate rpc docs. I think this PR is ready to merge.

@eval-exec eval-exec requested a review from doitian March 5, 2024 14:58
@doitian
Copy link
Member

doitian commented Mar 6, 2024

CI failed

@eval-exec
Execute make gen-rpc-doc
dc0f267 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec eval-exec force-pushed the exec/upgrade-toolchai-to-1.75.0 branch from 1e507c9 to dc0f267 Compare March 6, 2024 01:39
@eval-exec eval-exec requested a review from quake March 6, 2024 06:24
@doitian doitian added this pull request to the merge queue Mar 6, 2024
Merged via the queue into nervosnetwork:develop with commit 0ffa5a9 Mar 6, 2024
32 checks passed
@eval-exec eval-exec mentioned this pull request Mar 7, 2024
Open
@doitian doitian mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@driftluo driftluo driftluo left review comments

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@quake quake Awaiting requested review from quake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @doitian @driftluo