Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the openssl-vendored feature for the tentacle package to allow CKB to statically link with OpenSSL. #4320

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Enable the openssl-vendored feature for the tentacle package to allow CKB to statically link with OpenSSL. #4320

merged 3 commits into from
Jan 25, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jan 24, 2024 •
edited
Loading

What problem does this PR solve?

The easiest way to make ckb binary statically link SSL is to enable the openssl-vendored feature of the tentacle package.
Previously, we needed to compile OpenSSL dependencies in ckb-docker-builder which was cumbersome. Enabling openssl-vendored in CKB's tentacle dependency simplifies this. It makes our maintenance much easier.

What's Changed:

  • Enable openssl-vendored feature for tentacle
  • Delete "compile openssl from source code" part for CKB's release script

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • make CKB binary staticlly linked with OpenSSL.

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec added the t:ci Type: CI label Jan 24, 2024
@eval-exec eval-exec requested a review from a team as a code owner January 24, 2024 13:07
@eval-exec eval-exec mentioned this pull request Jan 24, 2024
Merged
@zhangsoledad zhangsoledad added this pull request to the merge queue Jan 25, 2024
Merged via the queue into nervosnetwork:develop with commit 2d03596 Jan 25, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
t:ci Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @quake @zhangsoledad