Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should only return main chain data #4182

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: should only return main chain data #4182

merged 1 commit into from
Oct 10, 2023

Conversation

quake
Copy link
Member

@quake quake commented Oct 10, 2023

What problem does this PR solve?

same as #4171 , when ckb node received GetBlocksProof and GetTransactionsProof message, it should return main chain data only.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@quake quake requested a review from a team as a code owner October 10, 2023 11:45
@quake quake requested review from zhangsoledad and yangby-cryptape and removed request for a team October 10, 2023 11:45
@quake quake merged commit 385bc89 into nervosnetwork:develop Oct 10, 2023
29 of 35 checks passed
@doitian doitian mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quake @yangby-cryptape @eval-exec