-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature of Replace-by-fee for tx-pool #4108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tx pool Replace-by-fee
quake
approved these changes
Aug 18, 2023
eval-exec
approved these changes
Aug 18, 2023
Closed
4 tasks
3 tasks
This was referenced May 30, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review is in #4079
What problem does this PR solve?
Add feature of Replace-by-fee for
tx-pool
.Fixes #3734
Problem Summary:
What is changed and how it works?
What's Changed:
This RBF feature enables users to replace a transaction with a higher fee rate when pending in
tx-pool
, which is useful when the transaction is stuck in thetx-pool
:min_rbf_rate
inckb.toml
with default value1500
, which means the minimum extra fee rate for RBF, the unit isshannons/KB
fee
andmin_replace_fee
inget_transaction
, which means the the minimal fee need to pay for RBF for a specific transactionmin_replace_fee = sum(replaced_tx_fee) + (min_rbf_rate * size)
tx-pool
and with the statusRejected
.Related changes
owner/repo
:Check List
Tests
Side effects
Release note