Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKCHANGE: refactor network config #361

Merged
merged 3 commits into from
Mar 27, 2019
Merged

BREAKCHANGE: refactor network config #361

merged 3 commits into from
Mar 27, 2019

Conversation

jjyr
Copy link
Contributor

@jjyr jjyr commented Mar 26, 2019

No description provided.

@jjyr jjyr requested review from quake, TheWaWaR, zhangsoledad and a team March 26, 2019 10:41
@jjyr
Copy link
Contributor Author

jjyr commented Mar 26, 2019

bors try

bors bot added a commit that referenced this pull request Mar 26, 2019
@bors
Try #361:
d048de6
@bors
Copy link
Contributor

bors bot commented Mar 26, 2019

try

Build failed

  • continuous-integration/travis-ci/push

@jjyr
Copy link
Contributor Author

jjyr commented Mar 26, 2019

bors try

bors bot added a commit that referenced this pull request Mar 26, 2019
@bors
Try #361:
bcad156
@bors
Copy link
Contributor

bors bot commented Mar 26, 2019

try

Build failed

  • continuous-integration/travis-ci/push

@doitian
Copy link
Member

doitian commented Mar 27, 2019

It seems the node stuck in the integration test.

@jjyr
Copy link
Contributor Author

jjyr commented Mar 27, 2019

bors try

bors bot added a commit that referenced this pull request Mar 27, 2019
@bors
Try #361:
7348c24
@jjyr jjyr changed the title refactor: network config BREAKCHANGE: refactor network config Mar 27, 2019
@bors
Copy link
Contributor

bors bot commented Mar 27, 2019

try

Build succeeded

  • continuous-integration/travis-ci/push

quake
quake requested changes Mar 27, 2019
View reviewed changes
network/src/network_config.rs Outdated Show resolved Hide resolved
@jjyr
Copy link
Contributor Author

jjyr commented Mar 27, 2019

bors r+

bors bot added a commit that referenced this pull request Mar 27, 2019
@bors @jjyr
Merge #361
ac2f29d 
361: BREAKCHANGE: refactor network config r=jjyr a=jjyr



Co-authored-by: jjy <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 27, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 4a1ecc7 into nervosnetwork:develop Mar 27, 2019
@doitian doitian mentioned this pull request Mar 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyr @doitian @quake