feat: use TryFrom convert protocol #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/sanitize_unwrap
branch
from
d843235 to
dd5f8b6
Compare
zhangsoledad
changed the title
zhangsoledad
requested review from
quake,
jjyr and
kilb
and removed request for
quake,
jjyr and
kilb
|
bors try |
quake
approved these changes
Mar 22, 2019
This comment has been minimized.
This comment has been minimized.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2019
350: feat: use TryFrom convert protocol r=doitian a=zhangsoledad Apply clippy lint fallible_impl_from : https://rust-lang.github.io/rust-clippy/v0.0.212/index.html#fallible_impl_from Co-authored-by: zhangsoledad <[email protected]>
Build succeeded
|
This was referenced Mar 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply clippy lint fallible_impl_from : https://rust-lang.github.io/rust-clippy/v0.0.212/index.html#fallible_impl_from