Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proposed pool remove committed #3269

Merged
merged 5 commits into from
Jan 17, 2022
Merged

fix: proposed pool remove committed #3269

merged 5 commits into from
Jan 17, 2022

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Jan 9, 2022 •
edited
Loading

What is changed and how it works?

  • fix proposed pool status inconsistent if remove_committed call with unexpect order.
  • improve tx-pool debug log
  • record reject orphan

Check List

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner January 9, 2022 18:12
quake
quake approved these changes Jan 10, 2022
View reviewed changes
test/src/specs/tx_pool/orphan_tx.rs Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/tx-pool-fix branch 2 times, most recently from aa4e359 to 33b7c47 Compare January 10, 2022 04:09
@quake quake changed the title fix: proposed pool remove committed [HOLD] fix: proposed pool remove committed Jan 14, 2022
@quake
Copy link
Member

quake commented Jan 14, 2022

waiting for godwoken test

@quake quake changed the title [HOLD] fix: proposed pool remove committed fix: proposed pool remove committed Jan 17, 2022
@quake
Copy link
Member

quake commented Jan 17, 2022

bors r=quake,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Jan 17, 2022

Build succeeded:

@bors bors bot merged commit b76272f into nervosnetwork:develop Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @yangby-cryptape