Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix declared cycles check #3077

Merged
merged 5 commits into from
Oct 11, 2021
Merged

fix declared cycles check #3077

merged 5 commits into from
Oct 11, 2021

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Oct 9, 2021 •
edited
Loading

What is changed and how it works?

Check declared cycles before submit.

Check List

Tests

  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix_check_declared_cycles branch from 7ff448f to 9c4d129 Compare October 9, 2021 08:11
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix_check_declared_cycles branch from 9c4d129 to 0697d2b Compare October 9, 2021 13:28
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix_check_declared_cycles branch from 0697d2b to 3eae257 Compare October 9, 2021 13:38
@zhangsoledad zhangsoledad marked this pull request as ready for review October 9, 2021 13:39
@zhangsoledad zhangsoledad requested a review from a team as a code owner October 9, 2021 13:39
@quake quake mentioned this pull request Oct 10, 2021
Closed
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix_check_declared_cycles branch from 3eae257 to 95815db Compare October 11, 2021 04:50
@quake
Copy link
Member

quake commented Oct 11, 2021

bors r=quake,driftluo

@bors
Copy link
Contributor

bors bot commented Oct 11, 2021

Build succeeded:

@bors bors bot merged commit b5ef49b into nervosnetwork:develop Oct 11, 2021
@zhangsoledad zhangsoledad deleted the zhangsoledad/fix_check_declared_cycles branch October 11, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@quake quake quake approved these changes

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape yangby-cryptape is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @driftluo