fix: graceful shutdown #3059
Merged
fix: graceful shutdown #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/graceful_shutdown
branch
from
939e0d0
to
8130d61
Compare
driftluo
approved these changes
Sep 29, 2021
yangby-cryptape
approved these changes
Oct 8, 2021
quake
approved these changes
Oct 8, 2021
|
bors r=quake,driftluo,yangby-cryptape |
bors bot
added a commit
that referenced
this pull request
Oct 8, 2021
3059: fix: graceful shutdown r=quake,driftluo,yangby-cryptape a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? Problem Summary: There are circular references between services, prevent terminate signal send before drop. ### What is changed and how it works? What's Changed: Introduce non-owning reference of controller does not count towards ownership. ### Related changes - PR to update `owner/repo`: - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: zhangsoledad <[email protected]>
|
Build failed: |
zhangsoledad
force-pushed
the
zhangsoledad/graceful_shutdown
branch
from
8130d61
to
5a038ad
Compare
zhangsoledad
force-pushed
the
zhangsoledad/graceful_shutdown
branch
from
5a038ad
to
15bbeb3
Compare
|
bors r=quake,driftluo,yangby-cryptape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: There are circular references between services, prevent terminate signal send before drop.
What is changed and how it works?
What's Changed: Introduce non-owning reference of controller does not count towards ownership.
Related changes
owner/repo:Check List
Tests
Release note