fix: fix identify disconnect #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
fix-identify-disconnect
branch
from
7af3ce1
to
a5b10d1
Compare
keroro520
suggested changes
Sep 24, 2021
keroro520
approved these changes
Sep 24, 2021
yangby-cryptape
approved these changes
Sep 24, 2021
|
bors r=keroro520,yangby-cryptape |
bors bot
added a commit
that referenced
this pull request
Sep 24, 2021
3052: fix: fix identify disconnect r=keroro520,yangby-cryptape a=driftluo ### What problem does this PR solve? fix https://github.com/nervosnetwork/ckb/runs/3673717980#step:4:1915 this ci fail 1. assert fail because the assert is wrong here, the `registered` behavior is before `received`, and the `discovery` in the test is broadcast every second. It is impossible to determine whether the node3 is just in the process of trying to connect when asserting. It can also be changed to `wait_connect_state(&node3, 1)`, but I don’t think it’s necessary, it’s no problem to delete it directly 2. When identify is closed, we should first check whether the current node information is banned and then insert the peer store, otherwise, the banned address may be spread ### Check List Tests - Unit test ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: driftluo <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: {"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r=keroro520,yangby-cryptape |
1 similar comment
|
bors r=keroro520,yangby-cryptape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix https://github.com/nervosnetwork/ckb/runs/3673717980#step:4:1915 this ci fail
registeredbehavior is beforereceived, and thediscoveryin the test is broadcast every second. It is impossible to determine whether the node3 is just in the process of trying to connect when asserting. It can also be changed towait_connect_state(&node3, 1), but I don’t think it’s necessary, it’s no problem to delete it directlyCheck List
Tests
Release note