Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rpc): change struct from "TxPoolVerbosity" to "TxPoolEntries… #3006

Merged
merged 1 commit into from
Sep 6, 2021
Merged

refactor(rpc): change struct from "TxPoolVerbosity" to "TxPoolEntries… #3006

merged 1 commit into from
Sep 6, 2021

Conversation

chanhsu001
Copy link
Contributor

Change "TxPoolVerbosity" to "TxPoolEntries", Change "TxVerbosity" to "TxPoolEntry"
for clear expressed, avoid ambiguity

What problem does this PR solve?

the word "TxPoolVerbosity", and "TxVerbosity" is ambiguous to used in the function/code
change them to "TxPoolEntries", and "TxPoolEntry", more clearly expressed.

Problem Summary:

What is changed and how it works?

change word in rpc/. and util/jsonrpc-types/.., run make gen-rpc-doc to update RPC readme

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Tests

  • No code (skip ci)
    already make ci pass

Side effects

Release note

None: Exclude this PR from the release note.

@yangby-cryptape
Copy link
Collaborator

yangby-cryptape commented Sep 2, 2021

These are BREAK CHANGES. This PR should have an release note.

And also this PR shouldn't be No code (skip ci).

@yangby-cryptape yangby-cryptape added b:rpc Break RPC interface breaking change The feature breaks consensus, database, message schema or RPC interface. and removed breaking change The feature breaks consensus, database, message schema or RPC interface. b:rpc Break RPC interface labels Sep 2, 2021
@yangby-cryptape
Copy link
Collaborator

I misunderstood at first. These are not break changes.

@chanhsu001
Copy link
Contributor Author

bors merge=doitian,quake

@bors
Copy link
Contributor

bors bot commented Sep 6, 2021

Build succeeded:

@bors bors bot merged commit d85fcd3 into nervosnetwork:develop Sep 6, 2021
@chanhsu001 chanhsu001 deleted the struct_word_change branch September 15, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants