feat: remove conflict pending for reorg #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
benchmark |
1 similar comment
|
benchmark |
zhangsoledad
force-pushed
the
zhangsoledad/earlier_clean_confilct_pending_tx
branch
from
6f452d0
to
d82b75d
Compare
zhangsoledad
force-pushed
the
zhangsoledad/earlier_clean_confilct_pending_tx
branch
2 times, most recently
from
a3f0145
to
a26d203
Compare
driftluo
approved these changes
Sep 7, 2021
doitian
approved these changes
Sep 16, 2021
zhangsoledad
force-pushed
the
zhangsoledad/earlier_clean_confilct_pending_tx
branch
from
a26d203
to
451c739
Compare
zhangsoledad
force-pushed
the
zhangsoledad/earlier_clean_confilct_pending_tx
branch
from
451c739
to
22ee4a1
Compare
zhangsoledad
force-pushed
the
zhangsoledad/earlier_clean_confilct_pending_tx
branch
from
22ee4a1
to
d4ea30b
Compare
|
bors r=driftluo,doitian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Previously, some conflict pending transactions may not be clean immediately, this does not affect the correctness，but will make developers who rely on
get_transactionget confused.What is changed and how it works?
Now, conflict pending transactions will be clean immediately after the new best block is committed.
Check List
Tests
tx-pool/src/component/tests/pending.rs
Release note